World: r3wp
[Core] Discuss core issues
older newer | first last |
Sunanda 29-Feb-2008 [9346] | Here's my contribution....It may not be as fast as others, but it relies on REBOL's inbuilt definition of a leap year, so no need to duplicate logic: leap?: func [date [date!] ][ return not error? try [print 1 to-date rejoin ["29-02-" date/year]] Seems to work on all border cases: 1899 --> 1904 ... 1999 --> 2004 ] |
Geomol 29-Feb-2008 [9347x7] | Sunanda, that's an interesting approach! :-) |
The diy would then be: diy: func [y] [either error? try [to-date join "29-02-" y] [365] [366]] :-) REBOL is wonderful! | |
Does anyone send emails to them? | |
Smallest readable version, I can produce: diy: func [y] [either attempt [to-date join "29-2-" y] [365] [366]] | |
oops, I exchanged 365 and 366. It should be: diy: func [y] [either attempt [to-date join "29-2-" y] [366] [365]] | |
Leap year *is* tricky! :-) | |
And the leap? function: leap?: func [year] [366 = diy year] | |
Sunanda 29-Feb-2008 [9354] | Nice work, guys. I tried emailing them the link to this discussion, but their server is overload so it did not get through -- must be too many people sending them solutions in obscure languages :-) http://www.rebol.org/cgi-bin/cgiwrap/rebol/aga-display-posts.r?post=r3wp157x9339 |
Gabriele 29-Feb-2008 [9355x2] | leap?: func [y] [2 = second to date! reduce [y 2 29]] |
(probably not any better than the above) | |
[unknown: 5] 29-Feb-2008 [9357] | drop one character and change the to date! to to-date. ;-) |
Geomol 29-Feb-2008 [9358x2] | Nice one, Gabriele! It's a force in REBOL, that you can do things in many ways. So we often find a way, that suit us well. Of cource it can also be a little confusing and hard to find the 'best' way for you. |
In most cases, we run circles around the other languages out there! :-) | |
Dockimbel 29-Feb-2008 [9360x6] | leap?: func [y][2 = second poke 29/02/2000 1 y] |
A bit faster, but I'm not sure it would work correctly on big-endian platforms. | |
Alternative ways : | |
leap?: func [y /local c][c: 29/02/2000 c/year: y c/month = 2] diy?: func [y][ 366 - to-integer to-logic any [ positive? y // 4 all [ zero? y // 100 positive? y // 400 ] ] ] | |
(to-logic is useless here and should be removed) | |
Btw, using the =? operator instead of = for the ending test in 'leap? would make it more readable for non-rebolers. | |
[unknown: 5] 29-Feb-2008 [9366x4] | Could also use REBOL's error handling routines such as: |
leap?: func [y][date? try [to-date join "29/2/" y ] | |
But that is not as efficient. | |
But it is short. | |
Gregg 29-Feb-2008 [9370x2] | So, if we had a built-in, or standard library implementation of LEAP-YEAR?, would you want it to be the shortest or fastest one? The easiest to understand? The most REBOLish? The various approaches people use in REBOL always makes me think about this, and how hard it is to choose sometimes. e.g. here's mine: leap-year?: func [ {Returns true if the specified year is a leap year; false otherwise.} year [date! integer!] /local div? ][ either date? year [year: year/year] [ if negative? year [throw make error! join [script invalid-arg] year] ] ; The key numbers are 4, 100, and 400, combined as follows: ; 1) If the year is divisible by 4, it’s a leap year. ; 2) But, if the year is also divisible by 100, it’s not a leap year. ; 3) Double but, if the year is also divisible by 400, it is a leap year. div?: func [n] [zero? year // n] to logic! any [all [div? 4 not div? 100] div? 400] ] |
Using REBOL to help figure it out, even with error trapping, seems very REBOLish. Also, My days-in-year func is based on leap-year?, rather than the other way around, and John did. | |
[unknown: 5] 29-Feb-2008 [9372] | Gregg, my preference is the one that offers the best performance. |
BrianH 29-Feb-2008 [9373x2] | My priority for library functions goes like this: 1. Stable 2. Fast 3. Easy to use 4. Easy to understand the implementation That last one is only for maintainability - otherwise it is not a priority at all for library code. |
Error trapping has a lot of overhead, so the more you can avoid basing your library code on it, the better off you will be. | |
[unknown: 5] 5-Mar-2008 [9375] | anyone know what stats/types counters are reflecting? i know when I add a block for example the counter remains the same value. |
btiffin 5-Mar-2008 [9376] | How transient are the blocks? REBOL seems to do a fair job of not over allocating. a: copy [] a: copy [] will only change the count by an entry, not two. a: copy [] insert/only a copy [] should change select stats/types 'block! by two or so. afaik |
[unknown: 5] 5-Mar-2008 [9377] | I figure if I created a block it would update the counter for each new block created as long as the older ones were still set as well. |
btiffin 5-Mar-2008 [9378] | Well, yes, but it could well replace an unused slot etc etc ... (I'm GC clueless) etc etc. Wrapped in recycle you should see the numbers change a little more sensibly. |
[unknown: 5] 6-Mar-2008 [9379] | That's just it Brian. All I did was open up the console and assigned a word a block value and check the stats/types for the block counter and it didn't change. I added another one and still didn't change. So I'm a bit perplexed. |
btiffin 6-Mar-2008 [9380] | Yeah, even after boot there are reallocatable blocks. Try recycle first thing in the console, then run the experiments. Once again, this is only afaik, 'cause I don't. |
Gregg 6-Mar-2008 [9381] | REBOL may allocate things in "pools" for efficiency. You shouldn't care Paul, except in extreme cases. |
[unknown: 5] 6-Mar-2008 [9382] | Yeah but if I know how they work I might be able to utilize that functionality in the future ;-) |
[unknown: 5] 7-Mar-2008 [9383x4] | Here is a total flatten function: |
b: func [blk [block!]][to-block trim/with mold/only blk "[]"] | |
forgot to name it - here instead: | |
flatten: func [blk [block!]][to-block trim/with mold/only blk "[]"] | |
BrianH 7-Mar-2008 [9387] | That kills the bindings of the words - is that intentional? |
[unknown: 5] 7-Mar-2008 [9388x5] | Yes it is intentional if someone wants to completely flatten a block. |
I can't see where someone would want to keep context if they are deciding to flatten it to that extreme. | |
I have a more useful flatten function that encompasses that one that will be more useful for someone that wants to keep contexts of no so flattened blocks. | |
It could probably be a mezz as it is very useful | |
Brian, I'll see if I can whip up my comprehensive flatten function to include a context sensitive full flatten and post it here. | |
BrianH 7-Mar-2008 [9393] | Here's a version which modifies in place: flatten: func [blk [block!] /local rule a b] [ parse blk [some [a: set b block! (change/part a b 1) :a | skip]] blk ] |
[unknown: 5] 7-Mar-2008 [9394] | Nice Brian |
BrianH 7-Mar-2008 [9395] | I've had to do something like it before. It doesn't preallocate or copy, but what can you do. |
older newer | first last |