World: r3wp

Thanks Anton, I'm poking around at all that

I'm not totally sure what this note from vid.r means:

	copy-text: func [face] [

   if not copy-selected-text [ ; copy all if none selected (!!! should 
   be line)
				system/view/highlight-start: face/text
				system/view/highlight-end: tail face/text
				copy-selected-text
			]
		]

Or at least I disagree.  I think the clipboard should be untouched 
if nothing is highlighted

Yeah. it sounds like the programmer didn't know a good user interface.

It's like one of those little cool things: "it'd be cool if it could 
also do this ..."

heh, yeah.  I agree with your solution, although it''s probably better 
to leave a shell of a function just to maintain backwards compatibility 
with scripts that perchance use copy-text

Yes, less changes required.

Scripts really shouldn't be using COPY-TEXT, at least not the "copy 
all" functionality. If that's what they wanted, they would more likely 
be accessing face/text directly or using access/get-face

It looks like the only thing on rebol.org that uses it is Volker's 
spell check style

What does his code use it for, though ? I'd be surprised if he uses 
it for the "copy all" functionality.

Its a patched clone of ctx-text, not my fault ;)

 ; copy all if none selected (!!! should be line

maybe it should not be "copy all", but "copy line with caret"? That 
would make sense, c-c c-v would double the current line.

Did a quick look through google, but only saw one thing.  I have 
not looked at RebGUI, but I assume Ashley has written his own copy-text 
functionality.

My preference would still be that it would not copy anything if nothing 
is selected.   I don't know what sort of behavior people would naturally 
expect from a text editor

I think the major annoyance is that it can't be undone....

Volker, aha not your fault !  Don't agree about copying the current 
line. It may look handy, but I still think if you want to copy the 
line, you should select the line first.   

Henrik, you mean undo as in the system clipboard should be able to 
go back to an older state ?

Or just that, since the system clipboard currently has no history, 
copying all text overwrites the clipboard too easily ?

anton, I just meant a plain undo in the editor to avoid destroying 
your text file, by accidental pasting.

I submitted a new ticket.   What are some of the other annoyances 
/ grievances people have with editor? or requested features?  I would 
like to join Henrik in fixing some of them.

it might not be a bug in the editor, but try to load a large file, 
and select text with the mouse. you can't push the text scrolling 
down, if you go beyond the upper or lower window edge

scrollling down or up

I think one of the French (Dide ?) made an AREA style with that functionality.

a simple line counter would be nice too

Didier Cadieu did make a nice area style.  It's available on the 
rebol.org site.  A year ago, I made some modifications to an earlier 
version of it, but I don't remember what I changed

Do you think editor should always start up with the last open file 
 (i.e. hit ctrl-E on desktop, open a file, close the editor, then 
hit ctrl-E again)

I would lean towards having it start blank each time

I don't think that behaviour should change...

Why do you think so?   My natural reaction is to expect something 
blank, or at least not have to close a file that I don't want open. 
  While you don't "close" a document in editor, I have to sit and 
think, "is this something that I want to be open right now or not?" 
   I find it disruptive from a UI standpoint

well, I always start the editor from the console, where I can type 
in a file name, a string, NONE or something else. that way I get 
always what I expect. :-)

I am strictly speaking of behavior using ctrl-E from the view desktop

haven't studied how that works...

Sorry, I wasn't clear from the start

It's just a simple line change in the View desktop.   In %vt-prefs.r 
, there keyboard map sets ctrl-E to                    [editor 'same] 
   I'm in favor of   [editor none]

But, I am working on getting a line count

ah yeah. that reminds me of another thing, which I reported in RAMBO 
#3934

i am in favor of a fixed file. [editor view-root/scratch.txt ]

Where would you place extra buttons?

Which extra buttons?

AFA line number / caret position, I would place it on a bar at the 
bottom of the editor

I will throw up a quick screen-shot as soon as I can get the proper 
setting for resizing

clean-script, diff, find/replace, such stuff.

josh, the bottom bar, wouldn't it be useful for small messages? "text 
'test' not found", "26 replacements done", "file saved", etc.

Yes!

About COPY-SELECTED-TEXT, I think too that without selection it just 
should not copy anything.

Maybe a new flag (copy-all ?) can be use to mark faces where you 
want a copy of all the text if there is no selection.

About mouse selection, yes you can find it on rebol.org.

Fortunately, you can select longer text with the keyboard (shift+down) 
:-)

hmm... how would I properly patch ctx-text's edit-text function?

It seems that I loose bindings on that function if I:

set in ctx-text 'edit-text func [newfunc]

Does anyone have a method for determining the line number in an area?

Henrik: try binding to ctx-text. Maybe thats all.

Josh. Yes. Somewhere.

It was something with offset-to-caret and parse string "^/" IIRC

If you have word wrap on you'll also have to calculate the width 
of the text field and find the wraps.