r3wp [groups: 83 posts: 189283]
  • Home
  • Script library
  • AltME Archive
  • Mailing list
  • Articles Index
  • Site search
 

World: r3wp

[View] discuss view related issues

DideC
18-Jan-2006
[4026]
Please, also consider some renaming.

flt-list => filter-list (more obvious)
get-row-here => get-current-row or get-selected-row
Graham
18-Jan-2006
[4027]
Henrik's vowel keys are broken on his keyboard!
DideC
18-Jan-2006
[4028x2]
get-col-here => get-this-current-col or get-this-selected-col
Not for Altme it seems :)
Henrik
18-Jan-2006
[4030]
didec, I'm thinking about it, but it'll break a whole lot of stuff, 
and I hate long variable names :-)
Ryan
18-Jan-2006
[4031x2]
get-col-pos
get-row-pos
Graham
18-Jan-2006
[4033]
Henrik, the main cost is in maintenance, and if you use abbrevs it's 
much harder for everyone to maintain later on.
Henrik
18-Jan-2006
[4034]
alright, I'll have a look at it
Graham
18-Jan-2006
[4035]
( don't look at my code though! )
Ryan
18-Jan-2006
[4036]
My keyboard misses alot of letters too.
Henrik
18-Jan-2006
[4037]
graham, I'll provide a translation table :-)
Ryan
18-Jan-2006
[4038]
for me the longer the program, longer the names.
Graham
18-Jan-2006
[4039]
it's just a search and replace.
DideC
18-Jan-2006
[4040]
Yes, but it's the interface of the style.

And an important thing I learn from Carl is "choose the right and 
shorter name that precicely describe what is it and avoid shortcuts". 
It come back in it's blog regularly.
BrianH
18-Jan-2006
[4041]
You may notice that Carl doesn't tend to skip the vowels in those 
names either (rebcode notwithstanding).
DideC
18-Jan-2006
[4042]
When I read 'change-row-here, I just wonder "Where?".

When I read 'change-selected-row, I know where. It also implied that 
it can happen that there is NO selected row.

If there is always a current row (but that is not always selected) 
then use 'change-current-row instead.
Ryan
18-Jan-2006
[4043]
what about change-row?
BrianH
18-Jan-2006
[4044]
Plus, consider multiple selected rows, which may or not include the 
current row.
Henrik
18-Jan-2006
[4045x3]
the way it works is that you have some basic retrieval functions, 
such as GET-ROW, GET-COL and such. They use fixed positions to get 
the row you want from DATA, such as if you want row number 6, you 
type in:

get-row 6


Then there are all the -HERE functions, which simply retrieve data 
from the selected rows and columns. If the name was to change, I'd 
probably go for GET-SELECTED-ROW and such.
works the same for inputting data
there is a problem with GET-SELECTED-COL, because it could be misinterpreted 
as you want to return the entire column, and not the single value 
at a specific position in a row. I've not adopted the term "cell", 
but would that be appropriate? I normally only associate it with 
spreadsheets.
Graham
18-Jan-2006
[4048]
it is a table cell though
Anton
18-Jan-2006
[4049]
Ryan, re CGI: Maybe try  size-text: none   at the beginning of the 
script ?  That "might" work.
Ryan
18-Jan-2006
[4050x2]
Anton: huge thanks! Brilliant, well, if it works. Perhaps plopping 
it in the user.r, rebol.r, or prefs file.
Henrik: what about using get-col-here as get-col with get-col/at 
to specify pos.
Henrik
18-Jan-2006
[4052]
ryan, that's a possibility
Ryan
18-Jan-2006
[4053]
selected behavior by default. seems nice.
Henrik
18-Jan-2006
[4054x2]
yeah, however there might be a slight confusion: Currently the -HERE 
functions take in account filtering and sorting, so that you always 
edit or retrieve the right row regardless of these settings. the 
other functions get and put directly in DATA. The behaviour would 
either need to change or I'd have to add another refinement
there could be a /direct refinement.
Volker
18-Jan-2006
[4056]
-marked ?
Henrik
18-Jan-2006
[4057x3]
(because I believe that direct editing of data would be rarely used, 
but I'm not entirely sure)
I don't use the term "marking" anywhere...
suggestion:

insert-row - would add a row at the selected position


insert-row/at - would add a row at the position that can be seen 
in the list after filtering and sorting


insert-row/at/direct - would add a row directly in DATA at the position

insert-row/direct - would be ignored? (I don't like that)
Ryan
18-Jan-2006
[4060]
poke-row?
Henrik
18-Jan-2006
[4061]
poke would be like change
Volker
18-Jan-2006
[4062]
/raw ? raw index?
Henrik
18-Jan-2006
[4063x2]
yeah, that would be good
insert-row/raw could be the way
Ryan
18-Jan-2006
[4065]
I dont know, good luck with that guys. Seems to have a whole lot 
of innuendo's. BTW Henrik, this is a very needed control, I commend 
your efforts!
Henrik
18-Jan-2006
[4066x2]
wait a minute... 'at is an existing function. will that work?
ryan, thanks :-)
Ryan
18-Jan-2006
[4068]
sys-at: get in system/words 'at
Volker
18-Jan-2006
[4069]
you must be carefull in that function. and use system/words/at for 
the real one.
Henrik
18-Jan-2006
[4070x2]
I don't think it's good, because I already use 'at in the raw functions
a less elegant option would be to use separate functions: INSERT-ROW, 
INSERT-ROW-AT, INSERT-ROW-RAW
Volker
18-Jan-2006
[4072]
first infunction::
  at-ref: at at: get in system/words 'at
and the rest can stay the same. not elegant, but..
Henrik
18-Jan-2006
[4073]
I don't like it...
Ryan
18-Jan-2006
[4074]
I dont love it
Henrik
18-Jan-2006
[4075]
or INSERT-ROW, INSERT-ROW/RAW and INSERT-ROW-AT