World: r3wp

Ok, sent.  some don't have the whitespace cropped at the top.

Currently the algorithm scans downwards and upwards simultaneously, 
looking for non-white content. When it doesn't find any, it has nowhere 
to crop to, so no cropping happens. I can change it so that when 
the scans bump into each other they set that as the "content found" 
position, and, the scan lines being right next to each other, will 
result in a 0-height crop region. I will check for that case and 
return none instead.

some don't lose some rubbish at the bottom.

The first one show this result, indeed. Let me analyse...

I understand the bug in my code. I did not implement the weighting 
quite correctly.

hmm.. more issues... it's complex when you want to scan from top 
and from bottom simultaneously.

Anton, I found that the  OCR engine I am using needs a white space 
border, so I am padding the image back again with a little white 
space.

That would help my algorithm. Text which is right up against the 
edge is likely to be classified as 'junk'. When there is text at 
the top edge and text at the bottom edge only, then we have two possibly 
'content' texts. But which one is the content and which is the junk 
? The algorithm is forced to either make a choice (which it could 
do by choosing the larger one), or not choose at all (which is what 
currently happens), so including both as the 'content'. If you put 
just one line of white outside the text you consider 'content' then 
it will be surrounded by white and the algorithm will select it as 
'content'.

I would always select the larger ...

Rewritten algorithm (selects the larger now).
load-thru/update these two:
http://anton.wildit.net.au/rebol/gfx/auto-crop-bitmap-text.r
http://anton.wildit.net.au/rebol/gfx/demo-auto-crop-bitmap-text.r
And download this new test script:
http://anton.wildit.net.au/rebol/gfx/test-auto-crop-bitmap-text.r

You can fiddle with the last script to make it load your 6 test files 
(which all yield correct looking results).

Cool.

if the region is blank, your scan routine returns none, and then 
the crop errors.

Oops, forgot the simplest input.

I've fixed that oversight. Update these files:
	auto-crop-bitmap-text.r 
	test-auto-crop-bitmap-text.r

The above update also cleans up loose words in the auto-crop-bitmap-text.r 
file.

I added a /pad option to mine so that it returns the text with a 
white space border.

which is needed for some ocr engines

/border
 makes more sense, doesn't it ?

maybe not...

updated 
	auto-crop-bitmap-text.r
removed old code and comments (file is 3.5k smaller)

updated again
	auto-crop-bitmap-text.r
replaced old comments with new ones.

Hmm.. I think the image padding might be outside the responsibility 
of an auto-crop function. Its job is to remove stuff, not add. It's 
probably better to write a small generalised function to do the padding 
(which could be useful elsewhere) and just feed the result of the 
auto-crop to it.

you're probably right

though it could be auto-crop to  as it were.

I think if you're going to make an "all-in-one" function, then its 
name should reflect that. eg. 
	crop-and-pad-ready-for-ocr: func [image][
		pad-image auto-crop-bitmap-text image 1x1
	]

(where pad-image is adding a 1x1 white border around the cropped 
image.)

auto-crop-bitmap-text: func ["Returns a cropped image, or none if 
the input image was blank"
	image [image!] 
	/local region
][
	if region: find-bitmap-text-crop-region image [ 

  copy/part skip image region/1 region/2  ; return a cropped image
	]
]

Looking at this, it appears to return unset! if region is none!

How about this 

	

auto-crop-bitmap-text: func ["Returns a cropped image, or none if 
the input image was blank"
	image [image!] 
	/local region
][
	all [
	 	region: find-bitmap-text-crop-region image  
		region: copy/part skip image region/1 region/2 
	]
	region
]

IF returns none when given false.

And your code redefines the meaning of 'region (which by itself is 
bad because it can cause confusion later) unnecessarily.
I could rewrite it more simply:
	all [
		region: find-bitmap-text-crop-region image
		copy/part skip image region/1 region/2
	]
but that's just equivalent to my IF above.

Ah ... ok.

I think it would be nice now to have the crop work on the sides as 
well.

Would it be hard to write a deskewing function?  basically I guess 
one finds a best fit horizontal line for the base of the text one 
finds, and then returns the angle needed to deskew it.

Is it really skew or do you mean rotate ?

It's normally called skew but it's the same.

To crop the right and left edges I think we can just rotate the image 
90 deg, crop it with the existing routines and then rotate it back 
again

Smart...

I was going to say that modifying the code to support horizontal 
cropping should be pretty easy. But that method is even easier !

(if a bit hackish.)

Seems to work ... but I have to rotate 270 deg and not -90 to get 
the original orientation back.  Does effect not take a negative rotation?

Seems to only do 0, 90, 180 and 270:
http://www.rebol.com/docs/view-system.html#section-9.5

Ahh.. that's no fun.  So, I can't use this to deskew.

Do you know, how to use DRAW to do image transformations?

nope

I usually learn enough about view to do something I need and then 
promptly forget it :(

You can rotate an image in DRAW like this:


view layout [box effect [draw [translate 40x0 rotate 60 image logo.gif]]]

that's how I'm doing the rotation now.

uhmm.. maybe not.

I'll try that out :)

( yes,  effect [draw [rotate]]  is different than  effect [rotate] 
)