World: r3wp
[!REBOL3]
older newer | first last |
Andreas 19-Oct-2010 [5446] | Should be easy using a simple custom dialect. |
GrahamC 19-Oct-2010 [5447x2] | and as part of the language? |
built in ... I mean | |
Andreas 19-Oct-2010 [5449] | Makes more sense to draft this in a simple function first, imho. |
GrahamC 19-Oct-2010 [5450] | Ok, ... can try it out |
BrianH 19-Oct-2010 [5451] | Not likely in direct syntax for two reasons: - P* is a valid word itself. - Word lookup is done by pointer comparison, not string comparison. |
GrahamC 19-Oct-2010 [5452] | so I could use a function that traverses the object doing string comparisons and returns the full path for me so I don't have to keep typing it |
Andreas 19-Oct-2010 [5453x3] | walk-path 'Obj/P*/D*/C*/Value |
Exactly. | |
Test results: A107: Total: 3822 Succeeded: 3769 Failed: 53 A108: Total: 3829 Succeeded: 3750 Failed: 79 | |
BrianH 19-Oct-2010 [5456] | These your tests? And did you redownload the build? |
Andreas 19-Oct-2010 [5457] | The publicly available testsuite. Yes. |
BrianH 19-Oct-2010 [5458] | Ah, we should check the tests to see if they are affected by the changes in semantics in A108. |
Andreas 19-Oct-2010 [5459] | I am looking thru the regressions now. |
BrianH 19-Oct-2010 [5460] | Also, see if there are any new tests succeeding. |
Andreas 19-Oct-2010 [5461x2] | https://gist.github.com/9457aa5b41bfd0b7edcb |
If anyone wants to join. | |
BrianH 19-Oct-2010 [5463x2] | Are the red lines failed tests? |
Also, # means none now. | |
Andreas 19-Oct-2010 [5465x3] | The green lines are new failures. |
The red lines are tests which no longer fail. | |
Yes, that's a case where the testsuite needs updating. | |
BrianH 19-Oct-2010 [5468] | Nice. |
Andreas 19-Oct-2010 [5469] | The first few new regressions indicate that the "make error!" semantics have changed. |
BrianH 19-Oct-2010 [5470] | DISARM has finally been removed. It has never been necessary in R3. |
Andreas 19-Oct-2010 [5471] | Yes. Would maybe make sense to keep it around for a while to warn that it is now gone. |
BrianH 19-Oct-2010 [5472] | We did that for more than a year. Now it is gone. |
Andreas 19-Oct-2010 [5473x2] | It only had a deprecation notice, no hard error (like e.g. LOAD/next has now). |
I personally don't care either way. | |
BrianH 19-Oct-2010 [5475] | The deprecation notice was in CureCode, when someone complained that it didn't work. From early 2009. |
Andreas 19-Oct-2010 [5476] | Yeah, and in the docstring. |
BrianH 19-Oct-2010 [5477x2] | Just looked back and we made that change in 2008. Wow. |
It predated CureCode :) | |
Andreas 19-Oct-2010 [5479x2] | The `make image!` errors in lines 42-43 seem to be real regressions. |
Seems complement no longer works on images and silently fails. | |
BrianH 19-Oct-2010 [5481] | The test on line 51 is a bug. See bug#1471, fixed in a108. |
Andreas 19-Oct-2010 [5482] | Yep. |
BrianH 19-Oct-2010 [5483x2] | 58 is the result of # now being none. |
And 75, 101, 102. | |
Andreas 19-Oct-2010 [5485] | Same for 75. |
BrianH 19-Oct-2010 [5486] | 112-122 are the result of fixing bug#1602. |
Andreas 19-Oct-2010 [5487x6] | 128-131 is # again. |
AS are 135-137 and 138-141. | |
And 150-152, 153-156. | |
Ok, and that's it. | |
170+ is a erronous paste of mine :) | |
Well, so that looks like one real regression (complement on image!). | |
BrianH 19-Oct-2010 [5493x2] | I think that the error codes are checked now. Fix all your tests that try to make errors with codes not in system/catalog/errors. |
176-180 are examples of this. | |
Andreas 19-Oct-2010 [5495] | Refresh the page. |
older newer | first last |