World: r3wp

The `make image!` errors in lines 42-43 seem to be real regressions.

Seems complement no longer works on images and silently fails.

The test on line 51 is a bug. See bug#1471, fixed in a108.

Yep.

58 is the result of # now being none.

And 75, 101, 102.

Same for 75.

112-122 are the result of fixing bug#1602.

128-131 is # again.

AS are 135-137 and 138-141.

And 150-152, 153-156.

Ok, and that's it.

170+ is a erronous paste of mine :)

Well, so that looks like one real regression (complement on image!).

I think that the error codes are checked now. Fix all your tests 
that try to make errors with codes not in system/catalog/errors.

176-180 are examples of this.

Refresh the page.

Or ignore everything past 170.

176-180 == 7-11 :)

Ok, 108 introduces 4 new errors (bad-header, bad-checksum, no-script, 
invalid-port-arg), renames 1 (bad-intrinsic to bad-sys-func) and 
changes the number of arguments for 1 (security-error)

Then some of the others must have been changed or renamed earlier.

The error IDs in the tests 7-10 do not exist in either A107 or A108.

And the error in 11 was renamed, as stated above.

Yup. I think that error code checking came in an earlier release.

So those are also things where the testsuite needs to be updated.

Well, maybe those are real regressions nevertheless.

At least the behaviour of error? has changed in this regard.

A107:
>> error? make error! [type: 'foo id: 'bar]
== true

A108:
>> error? make error! [type: 'foo id: 'bar]
** Script error: invalid argument: [type: 'foo id: 'bar]
** Where: make
** Near: make error! [type: 'foo id: 'bar]

I think we had a CC issue for that.

Nope, but the behavior of make error! has changed to actually trigger 
a *different* error if the error codes it is passed aren't in the 
catalog. ERROR? is the same.

ERROR? isn't called in those tests because MAKE error! triggers a 
different error first.

We had a CC issue for that, and the result was adding the error code 
checking to make error!.

The fix was is alpha 98.

was in

Something changed between A107 and A108.

A lot changed. What do you mean?

In this specific case.

Ah, I see.

>> make error! [type: 'foo id: 'bar]           
** foo error: (improperly formatted error)

Shouldn't have tested with type: 'script earlier :)

** script error
 and "** Script error" are fatally similar.

If the error checking of make error! itself is more strict in A108, 
cool :)

So the change is that `make error!` now is strict in what error types 
it accepts.

Yes, exactly.

Oh, it must have been to error! that was fixed in a98 in the same 
way. Cool.

Or it was "unfixed" somewhen between A98 and A107 :)

Good.

Should be noted on the changelog, though.

You should add some tests to verify that error code checking. I suggest 
TRY/except as a way to format the tests.