World: r3wp
[!REBOL3]
older newer | first last |
Andreas 26-Jan-2011 [7325] | ? |
BrianH 26-Jan-2011 [7326] | That would end up with bug reports like the ones for SORT not being stable. I would consider it a bug. |
Andreas 26-Jan-2011 [7327] | If it would be a bug otherwise, it is safe to document this behaviour. |
BrianH 26-Jan-2011 [7328] | The SORT not stable bug http://issue.cc/r3/1152is currently considered a "should fix before release" priority, btw. |
Kaj 26-Jan-2011 [7329] | Yes, SORT sucks, sort-a... |
Maxim 26-Jan-2011 [7330] | it would be nice to have a few sort algorythms out of the box. |
Kaj 26-Jan-2011 [7331x2] | That, too |
The only way I can currently use R3 is by replacing SORT | |
Andreas 26-Jan-2011 [7333] | Funny, me too :) |
Kaj 26-Jan-2011 [7334] | With a rewrite of Ladislav's msort. I'll probably publish it after a few more enhancements |
Andreas 26-Jan-2011 [7335] | I use a custom extension which stably wraps qsort :) I guess it is slower than msort, though :) |
Kaj 26-Jan-2011 [7336x3] | No idea, it works and it has hardly any effect on the total performance of my CMS, so I didn't test further |
This is what I have so far: | |
; Extended Merge Sort, originally by Ladislav Mecir, 2004 context [ set 'msort func [ table [series!] /skip size [integer!] /compare columns [integer! block!] /reverse ][ unless skip [size: 1] if size < length? table [sort table ; > 1 slot copy table (length? table) / size size either integer? columns [reduce [columns]] [columns] reverse ] table ] do-compare: func [ row1 row2 columns /local column a b ][ foreach column columns [ unless equal? a: pick row1 column b: pick row2 column [ return all [b any [not a a < b]] ] ] true ; Equal ] sort: func [ table shadow length [integer!] size columns reverse /local half middle ][ either length < 4 [ ; 2 or 3 slots if length = 3 [sort skip shadow size skip table size 2 size columns reverse] merge table shadow 1 skip shadow size length - 1 size columns reverse ][ middle: size * half: make integer! length / 2 sort shadow table half size columns reverse sort skip shadow middle skip table middle length: length - half size columns reverse merge table shadow half skip shadow middle length size columns reverse ] ] merge: func [ table shadow length shadow2 length2 size columns reverse ][ until [ either either reverse [do-compare shadow2 shadow columns] [do-compare shadow shadow2 columns] [ table: change table copy/part shadow size shadow: skip shadow size -- length zero? length ][ table: change table copy/part shadow2 size shadow2: skip shadow2 size -- length2 zero? length2 ] ] change change table copy/part shadow length * size copy/part shadow2 length2 * size ] ] | |
Ladislav 27-Jan-2011 [7339] | BTW, the last Msort: http://www.fm.tul.cz/~ladislav/rebol/msort.r is a bit faster than the older version you used |
Steeve 27-Jan-2011 [7340x3] | Got an iterative msort-do for R3: msort: func [s l /local mid end rest step][ forskip s 2 [ unless (compare s/1 s/2) [swap s next s] ] step: 2 loop -1 + log-2 l [ rest: forskip s step * 2 [ merge s step skip s step step s ] unless empty? end: skip rest step [ merge rest step end length? end ] step: step * 2 ] ] Not fully tested though...sorry |
* replace msort-do in Ladislav's implementation | |
Don't use forskip in R2, it's slow like hell | |
Maxim 27-Jan-2011 [7343] | yeah... FORSKIP is really overkilll just source it and you'll be amazed at how much code there is for a loop! also don't use FORALL..... cause it calls FORSKIP. always use UNTIL or WHILE in these cases. |
Steeve 27-Jan-2011 [7344] | but with R3, it's just fine |
Maxim 27-Jan-2011 [7345] | yeah... in R3 they're all native :-) |
Steeve 27-Jan-2011 [7346] | Kaj, you should find a way to fire all the <copy/part ... > you're doing. I would try to reuse the same buffer with something like: >> append/part clear buff ... |
Maxim 27-Jan-2011 [7347x2] | I use this often, though you have to be sure to copy the result somewhere... or else you get really spectacular bugs. this technique might also be task *unsafe*... It depends how functions will be shared amongst threads (copy or reference). |
unless you submit the buffer as an argument, of course. | |
Kaj 27-Jan-2011 [7349] | The copy/part's are an optimization of Ladislav's original version. I'll review the feedback here later |
Pekr 31-Jan-2011 [7350] | Wow, some bugfixing after looong months, cool :-) |
Henrik 31-Jan-2011 [7351] | >> sort/compare [d a c b] func [x [string!] y [string!]] [probe type? x x > y] word! word! word! word! word! word! word! == [d c b a] This is also a problem in R2. |
BrianH 31-Jan-2011 [7352x2] | Typespecs ignored: http://issue.cc/r3/1516 Sort not stable in R3: http://issue.cc/r3/1152 Those are the two problems that I know of that affect the above code. Did you mean something else? |
The second might not affect the code, if the == [d c b a] is not an error. | |
Henrik 31-Jan-2011 [7354] | type specs ignored, is the problem. |
BrianH 31-Jan-2011 [7355x2] | Right, [d c b a] is the correct order. Yes, #1516 is a really big (security) problem. |
Be sure to watch out for this too in R3: http://issue.cc/r3/1100 | |
Henrik 31-Jan-2011 [7357] | Thanks |
Mchean 2-Feb-2011 [7358x2] | nothing since Nov? |
nothing since Nov? | |
Henrik 2-Feb-2011 [7360] | bug fixing mode right now, and Carl is looking into encryption and SSL. |
Pekr 2-Feb-2011 [7361x2] | why SSL and encryption? |
Carl should get beta list out, not just choose another priority for next 3 months and then disappear again ... | |
Henrik 2-Feb-2011 [7363] | Because there is a process of determining how it should be done and it might make sense to prepare for it now. There are several possibilities for implementation. |
Maxim 2-Feb-2011 [7364x2] | really, if we have to choose between encryption and threads... there is no contest.... all the "usability" stuff we can code as extensions and indeed, the cURL binding is a good example of this. we need threads to be done... they have an over-arching effect on every aspect of REBOL... we can't put this off until later... its going to change the design of things for sure. I can't understand why Carl is side-stepping this again. |
is carl even aware that there is a cURL binding right now and that maybe he can skip this for now? | |
Pekr 2-Feb-2011 [7366] | I don't like the fact that Carl does not discuss the direction (beta list) with the group .... |
Kaj 2-Feb-2011 [7367] | Carl has handled cURL related bug reports, but chances are he doesn't know what it is :-) |
Maxim 2-Feb-2011 [7368] | in any case a tool like cURL is always going to be better since its being developped using standard tools which evolve and keep pace with changing specs and are bug fixed on their own. I'd rather that we be able to wrap cURL within schemes properly and that they be fixed or enhanced to make it happen. the core already has enough features... we need more architecture work and polishing. |
Pekr 2-Feb-2011 [7369] | Maxim - I don't necessarily agree. I would not like to see us departure from REBOL port model. I still think, that in the long run, protocols should be done directly in REBOL. |
Henrik 2-Feb-2011 [7370] | We already have a working prototype for a native SSL/TLS implementation. |
Pekr 2-Feb-2011 [7371] | Henrik - you mean from R2? |
Henrik 2-Feb-2011 [7372x2] | wait... I retract "working". I've not read the code, but Cyphre has done it a few days ago. |
Pekr, no a new implementation. | |
Maxim 2-Feb-2011 [7374] | pekr, as I understand it the system right now needs to be updated in order to allow external developpers to properly integrate into the port/scheme model. would be nice that this be addressed so that Kaj could have already done it. |
older newer | first last |