World: r3wp
[Red] Red language group
older newer | first last |
Dockimbel 11-Mar-2011 [259] | Your pull request disappeared, I guess you'll publish a new one. |
Steeve 11-Mar-2011 [260x2] | In one minute... |
sorry... | |
Dockimbel 11-Mar-2011 [262] | Oh, my bad, looking in the wrong repo...still need to adjust to the DCVS approach. |
Andreas 11-Mar-2011 [263x2] | The pull requests will appear in your repo (dockimbel/Red). |
Steeve's commits of course go to Steeve's repo :) | |
Dockimbel 11-Mar-2011 [265] | Sure, it's clear to me now. :-) |
Steeve 11-Mar-2011 [266] | I repulled a request. |
Dockimbel 11-Mar-2011 [267] | Ok, merging it to my Red repo... |
Steeve 11-Mar-2011 [268] | But, instead of seeing 2 commitments , I should have deleted the first one. Don't know how to do that though.... |
Dockimbel 11-Mar-2011 [269x3] | Done |
Steeve: have you tested the changes locally by compiling the hello script? | |
The power-of-2? function is not retro-compatible with the previous version. | |
Steeve 11-Mar-2011 [272] | eh ? |
Dockimbel 11-Mar-2011 [273] | Let me test that more closely... |
Steeve 11-Mar-2011 [274] | I've not tested with the compiler but the function itself |
Dockimbel 11-Mar-2011 [275x2] | The compiler chokes on the new version of this function, but works with the old one. |
It was missing a to-integer conversion: power-of-2?: func [n [integer!]][if zero? n - 1 and n [to integer! log-2 n]] | |
Steeve 11-Mar-2011 [277x2] | ah, yes sorry |
Should have tested with the compiler. sorry | |
Dockimbel 11-Mar-2011 [279] | Fixed. Thanks for the nice code reduction ;-) |
Steeve 11-Mar-2011 [280x2] | well it should be a little little faster aswell ;-) |
I saw some rooms for code factorization also, but you want it as fast as it can, I guess | |
Dockimbel 11-Mar-2011 [282] | For now, it's a prototype code, it doesn't need to be much micro-optimized as it will be fully rewritten in a few months using the Red language. |
Steeve 11-Mar-2011 [283x2] | I see that you use a lot, nested EITHER structures. Personnaly I prefer flat CASE structures, more readable. And i also think CASE could be faster. |
Yeah, it's temporary. | |
Dockimbel 11-Mar-2011 [285] | I guess you're looking at IA32.r/emit-path code? |
Steeve 11-Mar-2011 [286] | yes |
Dockimbel 11-Mar-2011 [287] | I need to factorize the code first, there's some redundancies, but it's also untested code. So, once it will work ok, I'll clean it up. |
Steeve 11-Mar-2011 [288] | Go Go Gadget |
Dockimbel 11-Mar-2011 [289x2] | :-) |
Btw, you've opened an issue ticket too...good opportunity for me to test github's tickets management options. | |
Steeve 11-Mar-2011 [291] | Hm... I did nothing though. |
Dockimbel 11-Mar-2011 [292x2] | It seems a ticket is opened for each pull request... |
I guess it's automated. | |
Steeve 11-Mar-2011 [294] | I just click ramdomly like a foul |
Dockimbel 11-Mar-2011 [295] | lol |
Steeve 11-Mar-2011 [296] | But how can I resync my fork, I wonder... I don't see your modification |
Dockimbel 11-Mar-2011 [297x2] | I guess you need to pull changes from my repo (dockimbel/Red) |
This is my commit: https://github.com/dockimbel/Red/commit/e9c6e78cf77ed388b688681d463a9960952f5a79 | |
Steeve 11-Mar-2011 [299x2] | got it it's in the 'fork queue' |
But I can't apply my previous commits, they failed. I just applied your commit and now it's ok. So it's ok. | |
Dockimbel 11-Mar-2011 [301] | Are you using a Git client or just github's web UI? |
Steeve 11-Mar-2011 [302x3] | Both of them. TortoiseGit on my PC |
I made a clone of my fork on my PC | |
I only forgot, that I must commit the both | |
Andreas 11-Mar-2011 [305x2] | steeve, locally do a "git pull --rebase" from doc's repo |
(that's the effect of one shortcoming of github's fork queue) | |
Dockimbel 11-Mar-2011 [307] | Good to know! |
Dockimbel 13-Mar-2011 [308] | Thanks to Andreas' help, we now have a first experimental support for Linux/ELF for Red/System. It's still very limited (basically just being able to call a system function with an argument), but it's a good start. It should be extended in the next days to support compilation of the hello.reds demo script. |
older newer | first last |