World: r4wp
[!REBOL3] General discussion about REBOL 3
older newer | first last |
Andreas 10-Mar-2013 [1552x2] | I'm not sure if the second is the desired change :) |
MarcS: one open questions is if we should use the __APPLE__ define (is that defined for iOS as well?) or rather use the R3-specific platform defines. | |
MarcS 10-Mar-2013 [1554] | Oh, did I misunderstand? |
Andreas 10-Mar-2013 [1555] | Win32 handles a none URL gracefully, just opening an "empty" browser. |
MarcS 10-Mar-2013 [1556] | Oh, okay. But this meets Brian's suggestion? |
Andreas 10-Mar-2013 [1557] | Yes. |
BrianH 10-Mar-2013 [1558] | A function should only return none if returning another value is a valid option. If it never returns a value, it shouyld return unset. |
MarcS 10-Mar-2013 [1559x2] | Incidentally, there's no simple way to browse to none using the current technique (as far as I can see). |
BrianH: oh okay, so this is a unit type / void. | |
BrianH 10-Mar-2013 [1561] | Yeah. |
MarcS 10-Mar-2013 [1562x3] | e.g., on MacOSX, open uses the format of its argument to determine the appropriate handler. I'd imagine xdg-open does the same. |
And i doubt browsing to file:/// is the desired default. | |
(Replace file:/// with anything else, I think the point stands.) | |
BrianH 10-Mar-2013 [1565] | Or desired to allow at all, right. |
Andreas 10-Mar-2013 [1566] | What does `open http://` do on OSX? |
MarcS 10-Mar-2013 [1567x2] | Incidentally, what's R3 bazaar? I was a little confused as to whether that was a repo for experimental developments or something else. |
Andreas: oh hey, about:blank | |
Andreas 10-Mar-2013 [1569] | (Same with xdg-open.) |
BrianH 10-Mar-2013 [1570] | It's MaxV's thing. |
MarcS 10-Mar-2013 [1571x3] | But xdg-open takes me to http:/// |
(Invalid adress.) | |
Brian: but pull requests should still go to the main repo? | |
Andreas 10-Mar-2013 [1574] | Yes. |
MarcS 10-Mar-2013 [1575x2] | address* |
(Sorry for the 20 questions.) | |
Andreas 10-Mar-2013 [1577] | Glad if we can help :) |
BrianH 10-Mar-2013 [1578] | browse none doesn't work right on Win32 unless IE is your default browser. It behaves differently wrong for every other default browser. |
MarcS 10-Mar-2013 [1579] | Aha, interesting. |
BrianH 10-Mar-2013 [1580] | Add that to the browse none ticket, Andreas, we can say "All Platforms". |
Andreas 10-Mar-2013 [1581x2] | So we probably better rather remove this feature altogether. |
> MarcS: one open question re your original pull is if we should use the __APPLE__ define > (is that defined for iOS as well?) or rather use the R3-specific platform defines. | |
BrianH 10-Mar-2013 [1583] | It would be worth taking none out of the argument spec and marking the ticket as a problem until we figure out how to do this correctly. |
MarcS 10-Mar-2013 [1584] | Stylistically I'd imagine Rebol's defines are preferred? |
BrianH 10-Mar-2013 [1585] | Yes please, if we have an appropriate one. And if we don't, we should. |
MarcS 10-Mar-2013 [1586] | But are they reliable? I can't see reference to either __APPLE__ or __MACH__ in the codebase |
Andreas 10-Mar-2013 [1587x2] | They are build-driven. |
You explicitly build for OSX, then the platform defines are set. | |
MarcS 10-Mar-2013 [1589x2] | TO_MAC, right? |
That isn't set correctly | |
Andreas 10-Mar-2013 [1591] | TO_OSXI and TO_OSX |
MarcS 10-Mar-2013 [1592] | Oh, thanks. |
Andreas 10-Mar-2013 [1593] | sys-system.h is unused, and only there to cause confusion :) |
MarcS 10-Mar-2013 [1594] | :) |
Andreas 10-Mar-2013 [1595] | The multitude of defines for platforms in the same "major" group is a bit of an annoyance as well. |
MarcS 10-Mar-2013 [1596] | hmm, so we'd need a disjunction |
Andreas 10-Mar-2013 [1597] | Yes, exactly. |
MarcS 10-Mar-2013 [1598] | TO_OSX || TO_OSXI |
BrianH 10-Mar-2013 [1599] | Is TO_OSX for all OSX or just PPC? |
MarcS 10-Mar-2013 [1600x2] | that's what this comment indicates |
src/include/reb-config.h:#ifdef TO_OSXI // OSX/Intel src/include/reb-config.h:#ifdef TO_OSX // OSX/PPC | |
older newer | first last |