World: r4wp
[!REBOL3] General discussion about REBOL 3
older newer | first last |
BrianH 10-Mar-2013 [1578] | browse none doesn't work right on Win32 unless IE is your default browser. It behaves differently wrong for every other default browser. |
MarcS 10-Mar-2013 [1579] | Aha, interesting. |
BrianH 10-Mar-2013 [1580] | Add that to the browse none ticket, Andreas, we can say "All Platforms". |
Andreas 10-Mar-2013 [1581x2] | So we probably better rather remove this feature altogether. |
> MarcS: one open question re your original pull is if we should use the __APPLE__ define > (is that defined for iOS as well?) or rather use the R3-specific platform defines. | |
BrianH 10-Mar-2013 [1583] | It would be worth taking none out of the argument spec and marking the ticket as a problem until we figure out how to do this correctly. |
MarcS 10-Mar-2013 [1584] | Stylistically I'd imagine Rebol's defines are preferred? |
BrianH 10-Mar-2013 [1585] | Yes please, if we have an appropriate one. And if we don't, we should. |
MarcS 10-Mar-2013 [1586] | But are they reliable? I can't see reference to either __APPLE__ or __MACH__ in the codebase |
Andreas 10-Mar-2013 [1587x2] | They are build-driven. |
You explicitly build for OSX, then the platform defines are set. | |
MarcS 10-Mar-2013 [1589x2] | TO_MAC, right? |
That isn't set correctly | |
Andreas 10-Mar-2013 [1591] | TO_OSXI and TO_OSX |
MarcS 10-Mar-2013 [1592] | Oh, thanks. |
Andreas 10-Mar-2013 [1593] | sys-system.h is unused, and only there to cause confusion :) |
MarcS 10-Mar-2013 [1594] | :) |
Andreas 10-Mar-2013 [1595] | The multitude of defines for platforms in the same "major" group is a bit of an annoyance as well. |
MarcS 10-Mar-2013 [1596] | hmm, so we'd need a disjunction |
Andreas 10-Mar-2013 [1597] | Yes, exactly. |
MarcS 10-Mar-2013 [1598] | TO_OSX || TO_OSXI |
BrianH 10-Mar-2013 [1599] | Is TO_OSX for all OSX or just PPC? |
MarcS 10-Mar-2013 [1600x2] | that's what this comment indicates |
src/include/reb-config.h:#ifdef TO_OSXI // OSX/Intel src/include/reb-config.h:#ifdef TO_OSX // OSX/PPC | |
Andreas 10-Mar-2013 [1602] | TO_OSX is osx-ppc, TO_OSXI is osx-intel |
BrianH 10-Mar-2013 [1603] | OK. Good to know. |
Andreas 10-Mar-2013 [1604] | And we have no common defines for "all of ..." at the moment, unfortunately. |
BrianH 10-Mar-2013 [1605] | My only Mac is a G5. |
MarcS 10-Mar-2013 [1606x4] | Hmm |
-#ifdef __APPLE__ +#if defined(TO_OSX) || defined(TO_OSXI) | |
neither are defined (unless I screwed that up!) | |
The only references I see in the codebase are the above ifdefs (reb-config.h) | |
Andreas 10-Mar-2013 [1610] | Should be defined and passed along in your makefile. |
MarcS 10-Mar-2013 [1611] | $ grep -R TO_OSX * src/include/reb-config.h:#ifdef TO_OSXI // OSX/Intel src/include/reb-config.h:#ifdef TO_OSX // OSX/PPC |
Andreas 10-Mar-2013 [1612] | in a make/makefile for osx-intel: TO_OS?= TO_OSXI ... RFLAGS= -c -D$(TO_OS) -DREB_API $(RAPI_FLAGS) $I HFLAGS= -c -D$(TO_OS) -DREB_CORE $(HOST_FLAGS) $I |
MarcS 10-Mar-2013 [1613x3] | hmm |
oh, mine reads TO_LINUX | |
shouldn't make prep have set that correctly? | |
Andreas 10-Mar-2013 [1616] | make make OS_ID=0.2.5 |
MarcS 10-Mar-2013 [1617] | Is there a reason that this isn't autodetected? |
Andreas 10-Mar-2013 [1618] | No good reason. But that's just how the build currently works. |
MarcS 10-Mar-2013 [1619] | Okay, thanks for the tip. |
BrianH 10-Mar-2013 [1620x2] | To support building Rebol for old crappy platforms with stupid make. |
At least that's the stated reason. There is likely a better approach. | |
MarcS 10-Mar-2013 [1622] | https://github.com/0branch/r3/commits/browse-macosx |
Andreas 10-Mar-2013 [1623] | http://issue.cc/r3/1991- BROWSE none |
MarcS 10-Mar-2013 [1624] | https://github.com/0branch/r3/commit/8eea3cf8217bd8f05ea5190fa81f5e8d8ed41cad |
Andreas 10-Mar-2013 [1625] | MarcS, with mainline R3 browse doesn't currently work on OSX, right? |
MarcS 10-Mar-2013 [1626x2] | Right |
Unless, I guess, you have XQuartz installed with xdg-open or x-www-browse | |
older newer | first last |