World: r4wp
[!REBOL3] General discussion about REBOL 3
older newer | first last |
MarcS 10-Mar-2013 [1609] | The only references I see in the codebase are the above ifdefs (reb-config.h) |
Andreas 10-Mar-2013 [1610] | Should be defined and passed along in your makefile. |
MarcS 10-Mar-2013 [1611] | $ grep -R TO_OSX * src/include/reb-config.h:#ifdef TO_OSXI // OSX/Intel src/include/reb-config.h:#ifdef TO_OSX // OSX/PPC |
Andreas 10-Mar-2013 [1612] | in a make/makefile for osx-intel: TO_OS?= TO_OSXI ... RFLAGS= -c -D$(TO_OS) -DREB_API $(RAPI_FLAGS) $I HFLAGS= -c -D$(TO_OS) -DREB_CORE $(HOST_FLAGS) $I |
MarcS 10-Mar-2013 [1613x3] | hmm |
oh, mine reads TO_LINUX | |
shouldn't make prep have set that correctly? | |
Andreas 10-Mar-2013 [1616] | make make OS_ID=0.2.5 |
MarcS 10-Mar-2013 [1617] | Is there a reason that this isn't autodetected? |
Andreas 10-Mar-2013 [1618] | No good reason. But that's just how the build currently works. |
MarcS 10-Mar-2013 [1619] | Okay, thanks for the tip. |
BrianH 10-Mar-2013 [1620x2] | To support building Rebol for old crappy platforms with stupid make. |
At least that's the stated reason. There is likely a better approach. | |
MarcS 10-Mar-2013 [1622] | https://github.com/0branch/r3/commits/browse-macosx |
Andreas 10-Mar-2013 [1623] | http://issue.cc/r3/1991- BROWSE none |
MarcS 10-Mar-2013 [1624] | https://github.com/0branch/r3/commit/8eea3cf8217bd8f05ea5190fa81f5e8d8ed41cad |
Andreas 10-Mar-2013 [1625] | MarcS, with mainline R3 browse doesn't currently work on OSX, right? |
MarcS 10-Mar-2013 [1626x2] | Right |
Unless, I guess, you have XQuartz installed with xdg-open or x-www-browse | |
Andreas 10-Mar-2013 [1628] | http://issue.cc/r3/1992- BROWSE doesn't work on OSX |
MarcS 10-Mar-2013 [1629x2] | Great. |
So should I submit pull requests referencing these tickets? | |
Andreas 10-Mar-2013 [1631] | Squash the two 1992-related commits into one, and also mention the CureCode ticket in the commit message (something like "This fixes CureCode issue #1992.") and submit a pull for that. |
MarcS 10-Mar-2013 [1632] | To squash I need to rebase locally then repush? |
Andreas 10-Mar-2013 [1633] | Yes, exactly (push --force). |
MarcS 10-Mar-2013 [1634] | Okay |
BrianH 10-Mar-2013 [1635] | For #1991 se need a better approach. We aren't at the point where we would need to disable a feature while we wait to figure it out, at least for something you have to explicitly call. |
Andreas 10-Mar-2013 [1636] | Hope you don't mind the cosmetics :) |
MarcS 10-Mar-2013 [1637] | Andreas: np, just testing the squashed changeset |
Andreas 10-Mar-2013 [1638] | For #1991, we should at least get the crash removed right away. |
MarcS 10-Mar-2013 [1639] | Sufficient detail, https://github.com/rebol/r3/pull/101? |
Andreas 10-Mar-2013 [1640] | Looks good. |
MarcS 10-Mar-2013 [1641] | https://github.com/rebol/r3/pull/102 |
Andreas 10-Mar-2013 [1642x3] | Let's hope Haiku has fork/exec :) |
Again, the second pull won't fly as-is. | |
If you can isolate the unset changes alone, that'd be great. | |
MarcS 10-Mar-2013 [1645x2] | Np. |
I figured I might as well submit the request so the code is more visible. | |
Andreas 10-Mar-2013 [1647] | Okay, that's fine, thanks. Just to have expectations aligned :) |
MarcS 10-Mar-2013 [1648] | Meanwhile I might merge that fix into my browse-macosx branch. |
Andreas 10-Mar-2013 [1649] | Just don't push the merged branch to Github again, as this will also affect the pull request. |
MarcS 10-Mar-2013 [1650x3] | Oh, right |
A third browse branch it is! | |
(As you might have gathered, I'm not much of a Githubber) | |
Andreas 10-Mar-2013 [1653] | For NONE I see the following options to fix the crash right away: either remove the NONE feature altogether (removing functionality that currently sometimes works on Win32), or use http:// on POSIX (as a not totally reliable workaround), or move the early exit to the POSIX specific code (creating a cross-platform incompatibility between Win32 and POSIX platforms). |
MarcS 10-Mar-2013 [1654x2] | Re: Haiku, http://code.metager.de/source/xref/haiku/headers/posix/unistd.h#212 |
Anyway, the subtree is named 'posix' :) | |
Andreas 10-Mar-2013 [1656] | Good, thanks for looking that up. I can try building on Haiku later on. |
MarcS 10-Mar-2013 [1657x2] | Great |
Git question: can I ignore changes to makefile without modifying .gitignore? | |
older newer | first last |